[5.7] Remove Hash::check() for password verification #25677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
|
I believe the problem continues in the laravel passport. When requesting token using password grant |
|
@crynobone @taylorotwell This is breaking change. Today I've updated my app from 5.7.2 to 5.7.4 and suddenly my authentication stopped working. The thing is that someone might have custom hasher created (as I have, not using |
|
We need to revert this. |
|
I don't agree with the framework checking on algo for password verification process, this PR was build to work around the BC made on 5.7.0. Personally I would prefer the algo check verification be made as a new method if one where really wanting strict algo verification such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 5.7.0, Laravel now verify the hash algorithm before using
password_verify(), while this is more secure for hashing in general this cause a regression bugs for password verification on authentication flow:bcryptto verifybcryptpassword, any older hashing is no longer supported. [5.7] Hash::check breaks all apps with legacy hash #25586bcryptto a stronger algorithm on your existing applications. [5.7] Mixing hashing algorithms not working #25458